Fix 4493 bug - TxWitness text envelope format does not roundtrip in Shelley era #4501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
requested review from
dcoutts,
erikd,
newhoggy,
JaredCorduan,
LudvikGalois and
CarlosLopezDeLara
as code owners
LudvikGalois
approved these changes
Oct 3, 2022
erikd
requested changes
Oct 3, 2022
Jimbo4350
force-pushed
the
jordan/4493-bug-fix
branch
2 times, most recently
from
a4e23fd to
a03072f
Compare
erikd
approved these changes
Oct 4, 2022
Fix 4493 bug - essentially the type field in the Shelley era text envelope tx body was being written to disk as "TxWitnessShelley" and being read from disk as "TxWitness Shelley". I.e there was a mismatch and therefore it was not possible to read shelley era transaction bodies. Closes: #4493
Jimbo4350
force-pushed
the
jordan/4493-bug-fix
branch
from
a03072f to
76beb9a
Compare
|
bors r+ |
Jimbo4350
changed the title
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #4493