removing dead code #2777
Merged
removing dead code #2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 10, 2022 11:50
This rule was moved to cardano-protocol-tpraos a while ago, and the version in Shelley should have been removed at that time.
lehins
approved these changes
May 10, 2022
nc6
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found two bits of dead code:
constructValidatedis not used anywhere in ledger, ouroboros-consensus, or cardano-node. It appears to be a helper function that we created for Alonzo before we redid how theIsValidtag works with consensus.UPDNrule was moved tocardano-protocol-tpraos, but somehow the old version still exists in the Shelley directory, and needs to be deleted.