Address deserialization #2750
Merged
Address deserialization #2750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/address-serialization
branch
from
1fbf81f
to
cd5c7d0
Compare
lehins
commented
Apr 25, 2022
JaredCorduan
approved these changes
Apr 25, 2022
There was a problem hiding this comment.
The bulk of the review was done in a call, thanks for all the context @lehins. looks good to me!
lehins
force-pushed
the
lehins/address-serialization
branch
from
32bb206
to
4d311a0
Compare
* Implement new more stringent deserialization for `Addr` and `RewardAcnt` * Add property tests for new decompacting method * Make Babbage `TxBody` use new deserialization, while keeping fromCBOR backwards compatible everywhere else * Update `cardano-base` and use newer `iohk-nix` sources * Add benchmarks for compacting/uncompacting of addresses * Add a benchmark that verifies lazy access to address fields
lehins
force-pushed
the
lehins/address-serialization
branch
from
4d311a0
to
d020487
Compare
lehins
dismissed
nc6’s stale review
Addressed Nicks feedback. Do not need to wait for rereview. Permission got from Jared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves performance of Address and RewardAcnt types, but most importantly it makes deserialization more stringent starting with Babbage. Fixes #2729
Requires IntersectMBO/cardano-base#274