hide CostModel constructor #2703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
approved these changes
Mar 25, 2022
eras/alonzo/test-suite/src/Test/Cardano/Ledger/Alonzo/Serialisation/Generators.hs
Outdated
Show resolved
Hide resolved
The CostModel constructor should have been hidden when the EvaluationContext was added to it, costModelParamsToCostModel is the appropriate smart constructor that everyone should use. The evaluation context is completely dependend on the cost model parameters.
JaredCorduan
force-pushed
the
jc/hide-cost-model-constructor
branch
from
4354289
to
60c1c9f
Compare
JaredCorduan
pushed a commit
that referenced
this pull request
Apr 18, 2022
In the Alonzo era, the map of languages to cost models was mistakenly encoded using an indefinite CBOR map (contrary to cannonical CBOR, as intended) when computing the script integrity hash. For this reason, PlutusV1 remains with this encoding. Future versions of Plutus, starting with PlutusV2 in the Babbage era, will use the intended definite length encoding. PR #2703 accidentally reversed this Alonzo bug, this commit restores it.
JaredCorduan
pushed a commit
that referenced
this pull request
Apr 18, 2022
In the Alonzo era, the map of languages to cost models was mistakenly encoded using an indefinite CBOR map (contrary to cannonical CBOR, as intended) when computing the script integrity hash. For this reason, PlutusV1 remains with this encoding. Future versions of Plutus, starting with PlutusV2 in the Babbage era, will use the intended definite length encoding. PR #2703 accidentally reversed this Alonzo bug, this commit restores it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CostModelconstructor should have been hidden when theEvaluationContextwas added to it,costModelParamsToCostModelis the appropriate smart constructor that everyone should use. The evaluationcontext is completely dependent on the cost model parameters.