Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement feesOK for babbage #2701

Merged
merged 2 commits into from
Mar 28, 2022
Merged

implement feesOK for babbage #2701

merged 2 commits into from
Mar 28, 2022

Conversation

goolord
Copy link
Contributor

@goolord goolord commented Mar 24, 2022 •
edited
Loading

No description provided.

@goolord goolord force-pushed the zc/babbage-feesOK branch 4 times, most recently from 9e27663 to 07927c5 Compare March 26, 2022 04:48
@goolord
Copy link
Contributor Author

goolord commented Mar 26, 2022 •
edited
Loading

huh, it looks like feesOK was defined in babbage twice and i missed the other one https://github.com/input-output-hk/cardano-ledger/blob/0ad3ccf55dd0c479d30ba2e1b33d7444a3a4282f/eras/babbage/impl/src/Cardano/Ledger/Babbage/Rules/Utxo.hs#L158 , but i think this one is closer to the spec, so i'm going to swap that one out for this one

JaredCorduan
JaredCorduan reviewed Mar 28, 2022
View reviewed changes
eras/babbage/impl/src/Cardano/Ledger/Babbage/Collateral.hs
collBalance txb (UTxO m) =
case collateralReturn' txb of
case getField @"collateralReturn" txb of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for syncing this up much better with the spec!

JaredCorduan
JaredCorduan approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@JaredCorduan JaredCorduan merged commit f852d0e into master Mar 28, 2022
@iohk-bors iohk-bors bot deleted the zc/babbage-feesOK branch March 28, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goolord @JaredCorduan