Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babbage unit tests #2681

Merged
merged 4 commits into from
Mar 10, 2022
Merged

babbage unit tests #2681

merged 4 commits into from
Mar 10, 2022

Conversation

JaredCorduan
Copy link
Contributor

@JaredCorduan JaredCorduan commented Mar 8, 2022

This PR adds two new units tests for some Babbage era features, namely:

  • using an inline datum
  • using a reference script

I also fixed some problems along the way. It might be easier to read this PR commit by commit. The fixes are:

  • I reverted the bump to the index-state, we can add it back when we resolve the problems with Update nix index #2677
  • I 🍒-picked the commit from @TimSheard 's PR Ts extended utxo class #2680 that added the ExtendedUTxO class.
  • I added another method to the ExtendedUTxO class, txscripts, so that we could reuse Alonzo functions and predicates.
  • I made it so that txOutDataHash no longer returns hashed inline datums. This function is fed into the HasField "datahash" instance, and I found it confusing for this "accessor" to retrieve the inline datums.

Copy link
Contributor

@TimSheard TimSheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small changes. Looks good to me.

Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Left a few suggestions

cabal.project Outdated Show resolved Hide resolved
eras/babbage/impl/src/Cardano/Ledger/Babbage/Scripts.hs Outdated Show resolved Hide resolved
eras/babbage/impl/src/Cardano/Ledger/Babbage/Scripts.hs Outdated Show resolved Hide resolved
@lehins lehins mentioned this pull request Mar 10, 2022
TimSheard and others added 2 commits March 10, 2022 11:28
This allow for re-use of several functions and predicates in the Babbage
era.
Jared Corduan added 2 commits March 10, 2022 14:35
@JaredCorduan JaredCorduan merged commit e66bee5 into master Mar 10, 2022
@iohk-bors iohk-bors bot deleted the jc/babbage_unit_tests branch March 10, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants