-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
babbage unit tests #2681
Merged
Merged
babbage unit tests #2681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimSheard
approved these changes
Mar 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small changes. Looks good to me.
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Examples/BabbageFeatures.hs
Outdated
Show resolved
Hide resolved
JaredCorduan
commented
Mar 10, 2022
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Examples/BabbageFeatures.hs
Outdated
Show resolved
Hide resolved
lehins
approved these changes
Mar 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Left a few suggestions
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Examples/TwoPhaseValidation.hs
Outdated
Show resolved
Hide resolved
Closed
This allow for re-use of several functions and predicates in the Babbage era.
JaredCorduan
force-pushed
the
jc/babbage_unit_tests
branch
from
March 10, 2022 19:24
c9e7b67
to
53d6058
Compare
* using an inline datum * using a reference script
JaredCorduan
force-pushed
the
jc/babbage_unit_tests
branch
from
March 10, 2022 19:36
53d6058
to
1d93d0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new units tests for some Babbage era features, namely:
I also fixed some problems along the way. It might be easier to read this PR commit by commit. The fixes are:
I reverted the bump to the index-state, we can add it back when we resolve the problems with Update nix index #2677ExtendedUTxO
class.ExtendedUTxO
class,txscripts
, so that we could reuse Alonzo functions and predicates.txOutDataHash
no longer returns hashed inline datums. This function is fed into theHasField "datahash"
instance, and I found it confusing for this "accessor" to retrieve the inline datums.