Make sure getDatum returns corect type. Rename isAdaOnly
#2671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
changed the title
getDatum returns corect type. Rename isAdaOlygetDatum returns corect type. Rename isAdaOnly
lehins
force-pushed
the
lehins/get-datum
branch
from
379c286
to
6048a54
Compare
TimSheard
approved these changes
Feb 25, 2022
There was a problem hiding this comment.
Looks good to me. Why did we rename adaOnly, is it just to use a consistent naming scheme for predicates? This is going to break Jared's PR where that function is used. But it should be easy to fix. Be sure all the tests pass, they are still running as I type.
JaredCorduan
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.