Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance txout with benchmarks #2668

Merged
merged 5 commits into from
Feb 25, 2022
Merged

Improve performance txout with benchmarks #2668

merged 5 commits into from
Feb 25, 2022

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Feb 24, 2022

This PR improves performance of TxOut and adds benchmarks. In particular serialization and TxOutCompact+TxOutCompactDH patterns

There is also a fix for couple of Babbage's TxOut accessor functions

@lehins lehins force-pushed the lehins/improve-performance-txout-with-benchmarks branch from 46c3fee to 2bb5089 Compare February 24, 2022 17:35
JaredCorduan
JaredCorduan approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! I only had one comment regarding changing a variable name 😬 which creates a diversion from two of the specs...

@lehins lehins force-pushed the lehins/improve-performance-txout-with-benchmarks branch from 2bb5089 to 8153e91 Compare February 24, 2022 23:37
@lehins lehins force-pushed the lehins/improve-performance-txout-with-benchmarks branch from 8153e91 to c4685da Compare February 24, 2022 23:50
@lehins lehins merged commit 1ae1bc7 into master Feb 25, 2022
@iohk-bors iohk-bors bot deleted the lehins/improve-performance-txout-with-benchmarks branch February 25, 2022 03:07
@lehins lehins mentioned this pull request Feb 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lehins @JaredCorduan