Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added generic (Era agnostic tests) in Test.Cardano.Ledger.Generic #2656

Merged
merged 2 commits into from
Feb 23, 2022

Conversation

TimSheard
Copy link
Contributor

Test.Cardano.Ledger.Generic.Properties is meant to someday replace Test.Cardano.Ledger.Properties
Added many PrettyA instances for UTXOW UTXO UTXOS PPUP predicate failures.
Cleaned up the broken Policy type.

…kage

Meant to someday replace Test.Cardano.Ledger.Properties
Add many PrettyA instances for UTXOW UTXO UTXOS PPUP predicate failures.
Cleaned up the broken Policy type.
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm excited to soon be able to use this code for making Babbage unit tests and examples! I think before we merge this we should make sure we only have one copy of the property tests (ie get rid of the alonzo specific ones in favor of the generic ones).

Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving, but I do hope we can reduce the duplication soon!

@JaredCorduan JaredCorduan merged commit e8ff740 into master Feb 23, 2022
@iohk-bors iohk-bors bot deleted the ts-generalizeProperties branch February 23, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants