Babbage era CDDL specification #2654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goolord
reviewed
Feb 14, 2022
Comment on lines
+75
to
+92
| transaction_output = legacy_Transaction_output / post_alonzo_transaction_output ; New | ||
|
|
||
| legacy_transaction_output = | ||
| [ address | ||
| , amount : value | ||
| , ? datum_hash : $hash32 | ||
| ] | ||
|
|
||
| ; Note that in the post_alonzo_transaction_output, we do not allow | ||
| ; a transaction output to include both a datum hash and a datum. | ||
| ; In other words, keys 2 and 3 are mutually exclusive. | ||
| post_alonzo_transaction_output = | ||
| { 0 => address | ||
| , 1 => value | ||
| , ? 2 => datum_hash | ||
| , ? 3 => datum ; New; inline datum | ||
| , ? 4 => script ; New; script reference | ||
| } |
There was a problem hiding this comment.
i like this 👍, how does deserializing the TxOut with cborg work though? do we decide how to branch by peekTokenType? cborg doesn't seem to have great machinery for deserializing choices
There was a problem hiding this comment.
Unfortunately I don't think that there is a way to handle it besides branching on peekTokenType.
JaredCorduan
force-pushed
the
jc/babbage-cddl
branch
from
770473a
to
f825178
Compare
JaredCorduan
commented
Feb 17, 2022
goolord
approved these changes
Feb 28, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first draft of the Babbage era CDDL specification