Proper fix for optimized version of isBootstrapRedeemer function.
#2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goolord
reviewed
Jan 25, 2022
eras/shelley/test-suite/src/Test/Cardano/Ledger/Shelley/Address/CompactAddr.hs
Show resolved
Hide resolved
goolord
reviewed
Jan 25, 2022
goolord
approved these changes
Jan 25, 2022
lehins
force-pushed
the
lehins/fix-is-bootstrap-redeemer
branch
from
9882747
to
cb1e021
Compare
JaredCorduan
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a test failure on CI, which can be reproduced with this command prior to this PR:
Original attempt to fix this was in #2284 which was invalid and resulted in the optimized version of the function not been used, however the test remained.
This is indeed a good optimization, since
returnRedeemAddrsToReservesiterates over the whole UTxO and current unoptimized version ofisBootstrapRedeemerwill cause redundant address uncompacting of all Shelley addresses