Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unspecialize test hash sizes #2620

Merged
merged 8 commits into from
Jan 21, 2022
Merged

Unspecialize test hash sizes #2620

merged 8 commits into from
Jan 21, 2022

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Jan 19, 2022

Avoid mock crypto when possible in favor of StandardCrypto.

Stop using small blake hashes for testing.

@lehins lehins changed the title Lehins/unspecialize test hashes Unspecialize test hash sizes Jan 19, 2022
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can make CI happy I think it is good to go. You did a lot of clean-up, much appreciated!

@lehins
Copy link
Collaborator Author

lehins commented Jan 20, 2022

@JaredCorduan Awesome. Thank you for the review.

I am still battling with one test case, so it is almost done.

@lehins lehins force-pushed the lehins/unspecialize-test-hashes branch from 75b953f to 68a9b64 Compare January 21, 2022 01:10
@lehins lehins force-pushed the lehins/unspecialize-test-hashes branch from 68a9b64 to 81f4e15 Compare January 21, 2022 08:50
@lehins lehins merged commit 0bb93fb into master Jan 21, 2022
@iohk-bors iohk-bors bot deleted the lehins/unspecialize-test-hashes branch January 21, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants