Document integrity hash in the case of no redeemer #2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredCorduan
force-pushed
the
jc/document-integrity-hash-when-no-redeemers
branch
from
6a0adc1
to
81a309f
Compare
JaredCorduan
force-pushed
the
jc/document-integrity-hash-when-no-redeemers
branch
from
81a309f
to
b3ed63c
Compare
redxaxder
approved these changes
Jan 19, 2022
iohk-bors
bot
deleted the
jc/document-integrity-hash-when-no-redeemers
branch
rooooooooob
added a commit
to Emurgo/cardano-serialization-lib
that referenced
this pull request
Feb 1, 2022
See IntersectMBO/cardano-ledger#2606 for documentation of this edge-case and IntersectMBO/cardano-ledger#2604 for the original issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents an unfortunate mistake. Harmless, but ugly.
When we added the ability to supply auxiliary datums (but only in the case of datums in newly created transaction outputs) we introduced this wart which arbitrarily prepends
80to the data and appendsA0, corresponding to the CBOR empty list and empty map.discovered by #2604