Fix the alonzo tx witness serialization #2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredCorduan
force-pushed
the
jc/fix-alonzo-txwit-serialization
branch
from
79a93f4
to
98fa9e3
Compare
Missing witness group should be entirely absent on the wire, not encoded as an empty list. We were encoding an empty list in the scenario that one type of script was present, but another type was absent, since the "Omit" check was checking too see if there were no scripts at all.
JaredCorduan
force-pushed
the
jc/fix-alonzo-txwit-serialization
branch
from
98fa9e3
to
9ab8559
Compare
redxaxder
approved these changes
Oct 19, 2021
nc6
approved these changes
Oct 19, 2021
JaredCorduan
commented
Oct 20, 2021
| isTimelock (TimelockScript _) = True | ||
| isTimelock (PlutusScript _ _) = False | ||
|
|
||
| isPlutus _ (TimelockScript _) = True |
There was a problem hiding this comment.
oh goodness 🤦 I will need to do a follow-up PR. cc @nc6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing witness group should be entirely absent on the wire, not encoded as an empty list. We were encoding an empty list in the scenario that one type of Plutus script was present, but another Plutus type was absent, since the
Omitcheck was checking to see if there were no scripts at all.I am hoping this unblocks IntersectMBO/ouroboros-network#3438