More TPraos separation #2518
Merged
More TPraos separation #2518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredCorduan
force-pushed
the
jc/more-tpraos-separation
branch
2 times, most recently
from
29a6af2
to
7fd7993
Compare
JaredCorduan
force-pushed
the
jc/more-tpraos-separation
branch
from
7fd7993
to
c0eb3fb
Compare
nc6
approved these changes
Oct 14, 2021
| boundedRationalFromCBOR, | ||
| boundedRationalToCBOR, | ||
| ) | ||
| import Cardano.Ledger.BaseTypes (ActiveSlotCoeff, NonNegativeInterval, ProtVer (..), ShelleyBase, UnitInterval, boundedRationalFromCBOR, boundedRationalToCBOR) |
There was a problem hiding this comment.
good catch! I would not do that on purpose, I must have done something to trigger omolu.
| activeSlotVal, | ||
| invalidKey, | ||
| ) | ||
| import Cardano.Ledger.BaseTypes (ActiveSlotCoeff, BoundedRational (..), NonNegativeInterval, ProtVer, UnitInterval, activeSlotVal, invalidKey) |
| randomnessStabilisationWindow, | ||
| securityParameter, | ||
| ) | ||
| import Cardano.Ledger.BaseTypes (BlocksMade, NonNegativeInterval, ProtVer, ShelleyBase, StrictMaybe (..), UnitInterval, activeSlotCoeff, epochInfo, maxLovelaceSupply, randomnessStabilisationWindow, securityParameter) |
| {-# LANGUAGE UndecidableInstances #-} | ||
| {-# OPTIONS_GHC -Wno-redundant-constraints #-} | ||
|
|
||
| module Cardano.Ledger.PoolDistr where |
There was a problem hiding this comment.
Can we document this module a bit? Just to provide a general idea of what a PoolDistr is and why it's a fundamental concept.
There was a problem hiding this comment.
absolutely! Thank you for reminding me recently about things that could be documented better, I need to do this more by reflex!
JaredCorduan
force-pushed
the
jc/more-tpraos-separation
branch
from
c0eb3fb
to
434cf77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes a few of the tasks remaining for separating TPraos from the ledger code (see #2462)
PoolDistr,IndividualPoolStakeandProtVerhave been moved to thecardano-ledger-corepackage.getLeaderSchedulewas moved to the Protocol API module, so that it does not need any TPraos imports. I'm not sure what to do with the Protocol API module, it may need to move to consensus.Cardano.Ledger.Prettynamespace, so I was not able to deprecate the old module. I think this is okay, I don't think any downstream libraries are using the pretty printers.COMPLETEpragma to some existing patterns.I removed the TPraos rules (OCERT,OVERLAYandTICKN) from the era mappings.