Skip to content
This repository has been archived by the owner on Feb 9, 2021. It is now read-only.

Additional state and check in the implementation of PVBUMP #720

Open
Vtec234 opened this issue Feb 10, 2020 · 1 comment
Open

Additional state and check in the implementation of PVBUMP #720

Vtec234 opened this issue Feb 10, 2020 · 1 comment
Labels
audit byron Required for a Byron mainnet: replace the old core nodes with cardano-node. priority medium issues/PRs that SHOULD be addressed. This should be done for the release, but acceptable if it doesn spec-alignment Tasks related to bringing the implementation to agree with the formal specification.

Comments

@Vtec234
Copy link

Vtec234 commented Feb 10, 2020

The specification of PVBUMP (fig. 44) keeps track of the protocol version and parameters but not the current epoch. Furthermore, it does not check whether the epoch has changed when invoked. In contrast, the implementation both has the epoch as extra state and checks whether there has been a change in epoch number. This is an entirely sensible thing to do, so this is just to note the difference.

@dcoutts dcoutts added audit spec-alignment Tasks related to bringing the implementation to agree with the formal specification. labels Feb 10, 2020
@nc6 nc6 added byron Required for a Byron mainnet: replace the old core nodes with cardano-node. priority medium issues/PRs that SHOULD be addressed. This should be done for the release, but acceptable if it doesn labels Feb 21, 2020
@nc6
Copy link
Contributor

nc6 commented Mar 20, 2020

This is changed in IntersectMBO/cardano-ledger#753

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
audit byron Required for a Byron mainnet: replace the old core nodes with cardano-node. priority medium issues/PRs that SHOULD be addressed. This should be done for the release, but acceptable if it doesn spec-alignment Tasks related to bringing the implementation to agree with the formal specification.
Projects
None yet
Development

No branches or pull requests

3 participants