Skip to content
This repository has been archived by the owner on Feb 9, 2021. It is now read-only.

Slot length changes should probably be ignored by the update system #642

Open
deepfire opened this issue Sep 23, 2019 · 5 comments
Open
Labels
byron Required for a Byron mainnet: replace the old core nodes with cardano-node. consensus Tickets that the fine folks over at ouroboros-consensus want to keep track of priority low Issues/RPs that are low priority issues/PRs in relation to a minimum Shelley testnet and Shelley mai

Comments

@deepfire
Copy link
Contributor

Currently slot length appears to be tracked in the update system state:

https://github.com/input-output-hk/cardano-ledger/blob/master/cardano-ledger/src/Cardano/Chain/Update/ProtocolParametersUpdate.hs#L148

..and https://github.com/input-output-hk/cardano-ledger/blob/master/cardano-ledger/src/Cardano/Chain/Update/Validation/Registration.hs#L338

This change in slot duration is replicated across update system state, but is however ignored, as far as I could see (i.e. it stays confined to the US state itself).

@dcoutts suggests we should change things, so this change is instead ignored as soon as the update proposal comes from the wire.

@deepfire
Copy link
Contributor Author

cc @dnadales

@deepfire deepfire changed the title Slot length should probably be ignored by the update system Slot length changes should probably be ignored by the update system Sep 23, 2019
@dnadales
Copy link
Contributor

dnadales commented Sep 23, 2019

A possible way of solving this is to just vanish the parameter: ignore the value on decoding, and use a fixed constant on encoding.

However, the important thing is to remove the slot length from any state we maintain. If it's still there in the data structure we read from the old chain format, that's not too important.

This is a nice to have, but not required for mainnet.

@edsko
Copy link
Contributor

edsko commented Sep 24, 2019

Related IntersectMBO/ouroboros-network#282.

@edsko edsko added byron Required for a Byron mainnet: replace the old core nodes with cardano-node. consensus Tickets that the fine folks over at ouroboros-consensus want to keep track of priority low Issues/RPs that are low priority issues/PRs in relation to a minimum Shelley testnet and Shelley mai labels Feb 5, 2020
@edsko
Copy link
Contributor

edsko commented Feb 5, 2020

Marking this as low priority, because consensus ignores this field entirely anyway.

@edsko
Copy link
Contributor

edsko commented Feb 5, 2020

Related: #494.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
byron Required for a Byron mainnet: replace the old core nodes with cardano-node. consensus Tickets that the fine folks over at ouroboros-consensus want to keep track of priority low Issues/RPs that are low priority issues/PRs in relation to a minimum Shelley testnet and Shelley mai
Projects
None yet
Development

No branches or pull requests

3 participants