Skip to content
This repository has been archived by the owner on Feb 9, 2021. It is now read-only.

Add roundtrip property tests and golden tests for UTxOValidationError CBOR instances #600

Open
mrBliss opened this issue Aug 2, 2019 · 4 comments
Assignees
Labels
byron Required for a Byron mainnet: replace the old core nodes with cardano-node. consensus Tickets that the fine folks over at ouroboros-consensus want to keep track of priority medium issues/PRs that SHOULD be addressed. This should be done for the release, but acceptable if it doesn testing

Comments

@mrBliss
Copy link
Contributor

mrBliss commented Aug 2, 2019

Background

#598 introduced ToCBOR and FromCBOR instances for UTxOValidationError. However, these instances do not have tests.

Proposed Solution

Write tests.

@intricate
Copy link
Contributor

Round-trip tests added in #628.

@intricate intricate self-assigned this Sep 4, 2019
@intricate
Copy link
Contributor

I still haven't gotten around to adding goldens.

@edsko edsko added byron Required for a Byron mainnet: replace the old core nodes with cardano-node. consensus Tickets that the fine folks over at ouroboros-consensus want to keep track of priority medium issues/PRs that SHOULD be addressed. This should be done for the release, but acceptable if it doesn testing and removed technical-debt labels Feb 5, 2020
@edsko
Copy link
Contributor

edsko commented Feb 5, 2020

Marking as medium priority since a change in binary format here will break the wallet.

@edsko
Copy link
Contributor

edsko commented Feb 5, 2020

Related: #710.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
byron Required for a Byron mainnet: replace the old core nodes with cardano-node. consensus Tickets that the fine folks over at ouroboros-consensus want to keep track of priority medium issues/PRs that SHOULD be addressed. This should be done for the release, but acceptable if it doesn testing
Projects
None yet
Development

No branches or pull requests

3 participants