feat(wallet): attempt to re-fetch tokenMetadata/nftMetadata if provid… #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirceahasegan
commented
Sep 26, 2022
mirceahasegan
commented
Sep 26, 2022
mkazlauskas
requested changes
Sep 27, 2022
mkazlauskas
previously approved these changes
Sep 27, 2022
rhyslbw
force-pushed
the
feat/re-fetch-token-and-nft-metadata-if-provider-returns-it-as-undefined
branch
from
147b1d0 to
2800f9c
Compare
rhyslbw
approved these changes
Sep 28, 2022
mkazlauskas
approved these changes
Sep 28, 2022
|
PR #466 must be merged before this one. |
mirceahasegan
commented
Sep 28, 2022
There was a problem hiding this comment.
PR #466 must be merged before this one.
Otherwise, nonNFT assets will poll forever because cardano-services returns undefined nftMetadata
rhyslbw
deleted the
feat/re-fetch-token-and-nft-metadata-if-provider-returns-it-as-undefined
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AssetInfo tokenMetadata/nftMetadata undefined means that the metadata could not be fetched.
We should still emit the partial AssetInfo, but also refetch refetch the metadata until it is successfully retrieved.
Proposed Solution
coldObservableProviderwithpollUntil, enabling it to retry until the condition is met.AssetsServicewillpollUntilAssetInfo tokenMetadata and nftMetadata are either null or definedImportant Changes Introduced