feat: remove async from fromBip39Entropy #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkazlauskas
requested changes
Jun 10, 2024
There was a problem hiding this comment.
Thanks for contribution! ❤️ Please also update the usages to not await:
Also it would be great to align the Bip32Ed25519 interface
| }); | ||
| static fromBip39Entropy(entropy: Buffer, password: string): Bip32PrivateKey { | ||
| const xprv = pbkdf2Sync( | ||
| password, |
mkazlauskas
reviewed
Jun 11, 2024
There was a problem hiding this comment.
Changes looks good! Need to resolve CI errors before merging, currently at
crypto/src/strategies/CmlBip32Ed25519.ts(24,10): error TS2416: Property 'fromBip39Entropy' in type 'CmlBip32Ed25519' is not assignable to the same property in base type 'Bip32Ed25519'.
which is probably asking to update async->sync in CmlBip32Ed25519
Yea I saw the build error this morning and wanted to fix this this afternoon. So just pushed, and gonna see if this fixes it. |
mkazlauskas
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
functions like
fromBip39Entropy()are essential for them to operate without being async, so upstream functions do not required async.Proposed Solution
pbkdf2replace withpbkdf2SyncImportant Changes Introduced
fromBip39Entropy()can removeawait