Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename stake-address-info field: stakeDelegation -> delegation for eras prior to Conway #487

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

carbolymer
Copy link
Contributor

Changelog

- description: |
    Rename stake-address-info field: stakeDelegation -> delegation for eras prior to Conway
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
   - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Copy link
Contributor

@carlhammann carlhammann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if we'll (I'll) probably have to rework this a bit more (see #417 and #353), it's good to keep track of this requirement by adding it to the code that's already commited.

@carbolymer carbolymer force-pushed the mgalazyn/fix/rename-stake-address-output-field branch from adfd2e2 to 7de7cfb Compare November 28, 2023 15:18
@carbolymer carbolymer requested review from a team as code owners November 28, 2023 15:18
@carbolymer carbolymer enabled auto-merge November 28, 2023 15:19
@carbolymer carbolymer added this pull request to the merge queue Nov 28, 2023
@carbolymer carbolymer removed this pull request from the merge queue due to a manual request Nov 28, 2023
@carbolymer carbolymer merged commit 1cc239c into main Nov 28, 2023
19 checks passed
@carbolymer carbolymer deleted the mgalazyn/fix/rename-stake-address-output-field branch November 28, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants