Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conway governance hash: add option to write hash to file (--out-file) #459

Merged
merged 4 commits into from
Nov 17, 2023

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Nov 16, 2023

Changelog

- description: |
    Add `--out-file` flag to `conway governance hash` command, so that it can write its result to a file (instead of only to stdout)
# uncomment types applicable to the change:
  type:
    - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #446

How to trust this PR

Execute cabal run cardano-cli -- conway governance hash --text foo --out-file out and witness out gets created

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc smelc changed the title Smelc/governance hash write to file conway governance hash: add option to write hash to file (--out-file) Nov 16, 2023
@smelc smelc force-pushed the smelc/governance-hash-write-to-file branch 2 times, most recently from 6636c93 to 6915ec0 Compare November 16, 2023 13:28
@smelc smelc marked this pull request as ready for review November 16, 2023 13:59
@smelc smelc force-pushed the smelc/governance-hash-write-to-file branch from 6915ec0 to 01e84d7 Compare November 17, 2023 10:09
@smelc smelc added this pull request to the merge queue Nov 17, 2023
@smelc smelc removed this pull request from the merge queue due to a manual request Nov 17, 2023
@smelc smelc added this pull request to the merge queue Nov 17, 2023
Merged via the queue into main with commit 4dcfd59 Nov 17, 2023
19 checks passed
@smelc smelc deleted the smelc/governance-hash-write-to-file branch November 17, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow conway governance hash to write output to a file
3 participants