Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#406 Enable use of inline datums in Babbage era transactions #407

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Oct 27, 2023

Changelog

- description: |
    Enable use of inline datums in Babbage era transactions
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
   - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carbolymer carbolymer added this pull request to the merge queue Oct 27, 2023
@carbolymer carbolymer removed this pull request from the merge queue due to a manual request Oct 27, 2023
@carbolymer carbolymer force-pushed the mgalazyn/fix/enable-inline-datums-in-babbage branch from 9d025e8 to 46fda57 Compare October 27, 2023 14:58
@carbolymer carbolymer enabled auto-merge October 27, 2023 14:58
@carbolymer carbolymer added this pull request to the merge queue Oct 27, 2023
Copy link
Contributor

@mkoura mkoura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression tests passed ✔️

Merged via the queue into main with commit e86aa60 Oct 27, 2023
19 checks passed
@carbolymer carbolymer deleted the mgalazyn/fix/enable-inline-datums-in-babbage branch October 27, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline datums cannot be used for Babbage era transactions
3 participants