Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command argument types for key commands #360

Merged
merged 5 commits into from
Oct 10, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Oct 10, 2023

Changelog

- description: |
    Command argument types for `key` commands
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

We are standardising on having a separate type to describe each command.

This PR refactors all the era-based key commands to this style in preparation for the next step which is to move some governance key commands into this command group.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review October 10, 2023 14:01
runConvertByronKeyCmd cmd
Cmd.KeyConvertByronGenesisVKeyCmd cmd ->
runConvertByronGenesisVKeyCmd cmd
Cmd.KeyConvertITNKeyCmd cmd ->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you find out if we need the ITN functionality anymore? If not we can remove all of that code.

@newhoggy newhoggy force-pushed the newhoggy/command-arg-types-for-key-commands branch from 956fdb9 to 965314c Compare October 10, 2023 22:11
@newhoggy newhoggy enabled auto-merge October 10, 2023 22:12
@newhoggy newhoggy added this pull request to the merge queue Oct 10, 2023
Merged via the queue into main with commit eb0e52b Oct 10, 2023
19 checks passed
@newhoggy newhoggy deleted the newhoggy/command-arg-types-for-key-commands branch October 10, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants