Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR template: remove that changelog extension is requested twice #343

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Oct 6, 2023

Changelog

- description: |
    Remove doublon in PR template
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Like IntersectMBO/cardano-api#285, but for cardano-cli this time

As visible in this PR, the Checklist section has a doublon regarding checking that the PR changelog is specified, it contains both:

The change log section in the PR description has been filled in

and

The changelog section in the PR is updated to describe the change

This PR removes the second entry.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • NA New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • NA The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@smelc smelc force-pushed the smelc/fix-doublon-in-pr-template branch from 67af823 to 78b369b Compare October 9, 2023 18:47
@smelc smelc force-pushed the smelc/fix-doublon-in-pr-template branch from 78b369b to 889bb5d Compare October 9, 2023 18:49
@smelc smelc enabled auto-merge October 9, 2023 18:49
@smelc smelc added this pull request to the merge queue Oct 9, 2023
Merged via the queue into main with commit 50733f7 Oct 9, 2023
@smelc smelc deleted the smelc/fix-doublon-in-pr-template branch October 9, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants