-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move files that are not golden files into input
directory
#327
Merged
newhoggy
merged 1 commit into
main
from
newhoggy/move-files-that-are-not-golden-files-to-input-directory
Oct 5, 2023
Merged
Move files that are not golden files into input
directory
#327
newhoggy
merged 1 commit into
main
from
newhoggy/move-files-that-are-not-golden-files-to-input-directory
Oct 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
requested review from
Jimbo4350,
carbolymer,
kevinhammond and
disassembler
as code owners
October 3, 2023 10:52
newhoggy
force-pushed
the
newhoggy/move-files-that-are-not-golden-files-to-input-directory
branch
from
October 3, 2023 11:00
187688f
to
21ead94
Compare
carbolymer
reviewed
Oct 3, 2023
cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/MultiSig/Address.hs
Outdated
Show resolved
Hide resolved
cardano-cli/test/cardano-cli-golden/Test/Golden/Shelley/Genesis/InitialTxIn.hs
Outdated
Show resolved
Hide resolved
cardano-cli/test/cardano-cli-golden/Test/Golden/Byron/UpdateProposal.hs
Outdated
Show resolved
Hide resolved
Yeah, those are annoying. The don't meet the criteria to be called golden (ie then don't regenerate), but they call themselves golden. |
I'll see if I can convert them to actually be golden. |
newhoggy
force-pushed
the
newhoggy/move-files-that-are-not-golden-files-to-input-directory
branch
2 times, most recently
from
October 3, 2023 12:45
ac11272
to
aac161a
Compare
I fixed the ones I could and renamed the rest to not be golden. |
newhoggy
force-pushed
the
newhoggy/move-files-that-are-not-golden-files-to-input-directory
branch
from
October 4, 2023 11:42
aac161a
to
b2275d0
Compare
Jimbo4350
approved these changes
Oct 4, 2023
newhoggy
force-pushed
the
newhoggy/move-files-that-are-not-golden-files-to-input-directory
branch
from
October 5, 2023 10:39
b2275d0
to
d52b178
Compare
newhoggy
deleted the
newhoggy/move-files-that-are-not-golden-files-to-input-directory
branch
October 5, 2023 11:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Golden files are only those files that can be generated with
CREATE_GOLDEN_FILES=1
.Any other files are not golden files and should go elsewhere. For example input files should go in the
input
directory.The benefit of this split is that you could
rm -rf
thegolden
directory knowing all the files within can be regenerated. This is a good way to figure out if any golden files are not longer in use.Checklist
See Running tests for more details
.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7