Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #311 - Add Cold Committee Key text envelope #323

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Oct 2, 2023

Changelog

- description: |
    Add Cold Committee Key text envelope
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
   - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #311

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/fix/add-cc-cold-key-envelope branch 2 times, most recently from c56a070 to fbe17fb Compare October 2, 2023 15:46
@carbolymer carbolymer marked this pull request as ready for review October 2, 2023 15:47
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to be able to sign with the committee hot key?

@carbolymer carbolymer force-pushed the mgalazyn/fix/add-cc-cold-key-envelope branch from fbe17fb to ae1ad15 Compare October 3, 2023 08:59
@carbolymer carbolymer force-pushed the mgalazyn/fix/add-cc-cold-key-envelope branch from ae1ad15 to d488bc4 Compare October 3, 2023 09:03
@carbolymer carbolymer requested review from a team as code owners October 3, 2023 09:03
@carbolymer carbolymer added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit b95fd9d Oct 3, 2023
20 checks passed
@carbolymer carbolymer deleted the mgalazyn/fix/add-cc-cold-key-envelope branch October 3, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transaction sign complains when signing with cc-cold-keys
3 participants