-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make transaction view
emit JSON
#319
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlhammann
requested review from
Jimbo4350,
newhoggy,
carbolymer,
kevinhammond and
disassembler
as code owners
September 29, 2023 16:14
newhoggy
reviewed
Sep 30, 2023
newhoggy
reviewed
Sep 30, 2023
newhoggy
approved these changes
Sep 30, 2023
carbolymer
reviewed
Oct 2, 2023
carbolymer
reviewed
Oct 2, 2023
carbolymer
reviewed
Oct 2, 2023
carbolymer
reviewed
Oct 2, 2023
carbolymer
approved these changes
Oct 2, 2023
carlhammann
force-pushed
the
ch/transaction-view-json
branch
from
October 9, 2023 09:19
5f50e6b
to
8b293df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
We discussed here that
cardano-cli
should output JSON by default. Thetransaction view
commands currently write YAML. This PR makes it so that YAML is only emitted by these commands with the option--output-format yaml
. I also added an--out-file
option to redirect the output to some file instead of stdout.Checklist
See Running tests for more details
.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7