Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#221 Update description fields on delegation certificates #250

Merged

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Sep 6, 2023

Changelog

- description: |
     Update description fields in delegation certificates from `Stake Address Delegation Certificate` to respectively (Conway onwards):
     - `Stake Delegation Certificate` 
     - `Vote Delegation Certificate`
     - `Stake and Vote Delegation Certificate`
  type:
   - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Closes #221

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy self-requested a review September 6, 2023 13:17
@carbolymer carbolymer added this pull request to the merge queue Sep 6, 2023
Merged via the queue into main with commit ab42088 Sep 6, 2023
22 checks passed
@carbolymer carbolymer deleted the mgalazyn/feature/update-description-fields-on-deleg-certs branch September 6, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update description fields on Delegation certificates
3 participants