Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable redundant-constraints warning only on ghc-8.10.7 #245

Merged

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Sep 5, 2023

Changelog

- description: |
    Disable `redundant-constraints` warning only on `ghc-8.10.7`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

It is not having this warning on in ghc-8.10.7 if it incurs the use of CPP. We can rely on new ghc compilers to prevent use merging redundant constraints code to main.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review September 5, 2023 10:49
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails on 9.2 in CI. Either we drop 9.2 support, or we should still support it.

@newhoggy newhoggy force-pushed the newhoggy/disable-redundant-constraints-only-on-ghc-8.10.7 branch from 5d68efa to 40179e5 Compare September 5, 2023 12:25
@newhoggy newhoggy requested a review from carbolymer September 5, 2023 13:02
@newhoggy newhoggy dismissed carbolymer’s stale review September 5, 2023 13:02

Comments addressed

@newhoggy newhoggy force-pushed the newhoggy/disable-redundant-constraints-only-on-ghc-8.10.7 branch from 40179e5 to 0d00850 Compare September 6, 2023 13:04
@newhoggy newhoggy enabled auto-merge September 6, 2023 13:59
@newhoggy newhoggy added this pull request to the merge queue Sep 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 6, 2023
@newhoggy newhoggy force-pushed the newhoggy/disable-redundant-constraints-only-on-ghc-8.10.7 branch from 0d00850 to 1f0f4b6 Compare September 6, 2023 23:00
@newhoggy newhoggy enabled auto-merge September 6, 2023 23:04
@newhoggy newhoggy added this pull request to the merge queue Sep 6, 2023
Merged via the queue into main with commit e199a35 Sep 6, 2023
19 checks passed
@newhoggy newhoggy deleted the newhoggy/disable-redundant-constraints-only-on-ghc-8.10.7 branch September 6, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants