Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure both proposal and constitution related commands will accept text, file and hash #218

Merged
merged 5 commits into from
Sep 1, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Aug 29, 2023

Changelog

- description: |
    Ensure both proposal and constitution related commands will accept text, file and hash
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Ensure both proposal and constitution related commands will accept text, file and hash.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy changed the title Newhoggy/fix new constitution command fixes Fix new constitution command fixes Aug 29, 2023
@newhoggy newhoggy marked this pull request as ready for review August 29, 2023 15:31
@newhoggy newhoggy changed the title Fix new constitution command fixes New constitution command fixes Aug 29, 2023
@newhoggy newhoggy changed the title New constitution command fixes WIP New constitution command fixes Aug 29, 2023
@newhoggy newhoggy force-pushed the newhoggy/fix-new-constitution-command-fixes branch 4 times, most recently from 95ac9f6 to 337e504 Compare August 31, 2023 11:40
@newhoggy newhoggy changed the title WIP New constitution command fixes Constitution and proposal command fixes Aug 31, 2023
@newhoggy newhoggy changed the title Constitution and proposal command fixes Ensure both proposal and constitution related commands will accept text, file and hash Aug 31, 2023
= ReadSafeHashErrorNotHex ByteString String
| ReadSafeHashErrorInvalidHash Text

renderReadSafeHashError :: ReadSafeHashError -> Text
Copy link
Contributor

@carbolymer carbolymer Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be an Error instance instead of rendering function.

@newhoggy newhoggy force-pushed the newhoggy/fix-new-constitution-command-fixes branch from 337e504 to 12ef325 Compare September 1, 2023 20:34
@newhoggy newhoggy enabled auto-merge September 1, 2023 20:34
@newhoggy newhoggy added this pull request to the merge queue Sep 1, 2023
Merged via the queue into main with commit 335daac Sep 1, 2023
@newhoggy newhoggy deleted the newhoggy/fix-new-constitution-command-fixes branch September 1, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants