Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add legacy prefix to legacy run commands #217

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Aug 29, 2023

Changelog

- description: |
    Add legacy prefix to legacy run commands
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This will ensure that the era-based run commands and legacy commands are named differently so the legacy commands can delegate them without confusion.

Governance legacy commands were not modified in this PR (this will be done separately) because there is a legacy governance PR that already does this.

The PR also ensures all legacy run commands have a Cmd suffix.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review August 29, 2023 11:19
@newhoggy newhoggy force-pushed the newhoggy/add-legacy-prefix-to-legacy-run-commands branch from bbfb63e to 3198849 Compare August 29, 2023 11:20
@newhoggy newhoggy force-pushed the newhoggy/add-legacy-prefix-to-legacy-run-commands branch from c0088eb to 3198849 Compare August 29, 2023 15:31
@newhoggy newhoggy force-pushed the newhoggy/add-legacy-prefix-to-legacy-run-commands branch from 3198849 to c3f8eed Compare August 30, 2023 00:22
@newhoggy newhoggy added this pull request to the merge queue Aug 30, 2023
Merged via the queue into main with commit 10cb5d0 Aug 30, 2023
19 checks passed
@newhoggy newhoggy deleted the newhoggy/add-legacy-prefix-to-legacy-run-commands branch August 30, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants