Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add governance query commands #189

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Add governance query commands #189

merged 1 commit into from
Aug 28, 2023

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Aug 18, 2023 •
edited
Loading

Changelog

- description: |
    Add governance query commands
# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Requires:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/feature/expose-more-governance-queries branch 6 times, most recently from 1ee1a2e to f786349 Compare August 22, 2023 14:17
carbolymer
carbolymer commented Aug 22, 2023
View reviewed changes
cardano-cli/src/Cardano/CLI/EraBased/Run/Governance.hs Outdated
( newExceptT $ executeLocalStateQueryExpr localNodeConnInfo Nothing $ queryDRepStakeDistribution eraInMode sbe dreps)
& onLeft (left . GovernanceCmdUnsupportedNtcVersion)
& onLeft (left . GovernanceCmdEraMismatch)
let serializedGovState = encodePretty $ Map.assocs drepStakeDistribution
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will end up as a list of 2-element lists in JSON.

@carbolymer carbolymer force-pushed the mgalazyn/feature/expose-more-governance-queries branch 5 times, most recently from 2ad9025 to ff56f5e Compare August 24, 2023 07:09
@carbolymer carbolymer force-pushed the mgalazyn/feature/expose-more-governance-queries branch 2 times, most recently from 84d8e55 to 5e98c87 Compare August 25, 2023 12:16
@carbolymer carbolymer force-pushed the mgalazyn/feature/expose-more-governance-queries branch 3 times, most recently from 3a8e53b to 1942ab4 Compare August 25, 2023 14:46
@carbolymer carbolymer changed the title Expose more governance queries Add governance query command Aug 25, 2023
@carbolymer carbolymer changed the title Add governance query command Add governance query commands Aug 25, 2023
@carbolymer carbolymer force-pushed the mgalazyn/feature/expose-more-governance-queries branch 4 times, most recently from ec7f50d to ac961e4 Compare August 25, 2023 15:47
@carbolymer
Copy link
Contributor Author

carbolymer commented Aug 25, 2023 •
edited
Loading

CI failures are coming from relying on an unreleased version of cardano-api. To be fixed prior to merge.

@carbolymer carbolymer marked this pull request as ready for review August 25, 2023 15:48
Jimbo4350
Jimbo4350 approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 . One minor comment

cardano-cli/src/Cardano/CLI/EraBased/Options/Governance/Query.hs Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Read.hs Outdated Show resolved Hide resolved
cardano-cli/test/cardano-cli-golden/files/golden/help.cli Show resolved Hide resolved
disassembler
disassembler previously requested changes Aug 26, 2023
View reviewed changes
Copy link
Contributor

@disassembler disassembler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a newer API version than what is currently released, which in turn needs a lot of changes to adopt txVotes -> txVotingProcedures among other things.

cardano-cli/src/Cardano/CLI/EraBased/Run/Governance/Query.hs Show resolved Hide resolved
@carbolymer carbolymer force-pushed the mgalazyn/feature/expose-more-governance-queries branch from ac961e4 to 6367b97 Compare August 28, 2023 09:35
@carbolymer carbolymer force-pushed the mgalazyn/feature/expose-more-governance-queries branch from 6367b97 to f279085 Compare August 28, 2023 09:43
@carbolymer carbolymer requested review from a team as code owners August 28, 2023 09:43
@carbolymer carbolymer dismissed disassembler’s stale review August 28, 2023 09:43

Updated cardano-api dep to 8.16.2

@carbolymer carbolymer enabled auto-merge August 28, 2023 09:44
@carbolymer carbolymer added this pull request to the merge queue Aug 28, 2023
Merged via the queue into main with commit 342bac8 Aug 28, 2023
@carbolymer carbolymer deleted the mgalazyn/feature/expose-more-governance-queries branch August 28, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@disassembler disassembler disassembler left review comments

@newhoggy newhoggy Awaiting requested review from newhoggy

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carbolymer @disassembler @Jimbo4350