Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#128 DRep key generation #163

Merged
merged 1 commit into from
Aug 14, 2023
Merged

#128 DRep key generation #163

merged 1 commit into from
Aug 14, 2023

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Aug 10, 2023

Changelog

- description: |
    CLI command 'drep cardano-cli conway governance drep key-gen` for DRep key generation

# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Implements #128

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/feature/drep-key-gen branch from fcde5c2 to dac240a Compare August 10, 2023 17:53
@carbolymer carbolymer force-pushed the mgalazyn/feature/drep-key-gen branch 3 times, most recently from d53bd49 to e2fba65 Compare August 10, 2023 18:07
@carbolymer carbolymer requested review from Jimbo4350 and newhoggy and removed request for Jimbo4350 August 10, 2023 18:10
@carbolymer carbolymer marked this pull request as ready for review August 10, 2023 18:10
@carbolymer carbolymer force-pushed the mgalazyn/feature/drep-key-gen branch from e2fba65 to 7ed0484 Compare August 10, 2023 18:17
Setup.hs Show resolved Hide resolved
@newhoggy
Copy link
Contributor

This looks good and is low risk because it is only adding code.

@carbolymer carbolymer force-pushed the mgalazyn/feature/drep-key-gen branch from cbfbf8e to e43efc3 Compare August 14, 2023 12:47
@carbolymer carbolymer requested review from a team as code owners August 14, 2023 12:47
Setup.hs Show resolved Hide resolved
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but we should consider my comment: #163 (comment)

@@ -69,3 +73,4 @@ renderEraBasedGovernanceCmds = \case
renderGovernanceCommitteeCmds cmds
EraBasedGovernanceActionCmds cmds ->
renderGovernanceActionCmds cmds
EraBasedGovernanceDRepGenerateKey{} -> "governance drep key-gen"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about having a single key generation command that generates all the different keys? cc: @newhoggy @disassembler

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like a really good idea!

@carbolymer carbolymer enabled auto-merge August 14, 2023 13:32
@carbolymer carbolymer added this pull request to the merge queue Aug 14, 2023
Merged via the queue into main with commit fddb87d Aug 14, 2023
@carbolymer carbolymer deleted the mgalazyn/feature/drep-key-gen branch August 14, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants