-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#128 DRep key generation #163
Conversation
fcde5c2
to
dac240a
Compare
d53bd49
to
e2fba65
Compare
e2fba65
to
7ed0484
Compare
7ed0484
to
cbfbf8e
Compare
This looks good and is low risk because it is only adding code. |
cbfbf8e
to
e43efc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but we should consider my comment: #163 (comment)
@@ -69,3 +73,4 @@ renderEraBasedGovernanceCmds = \case | |||
renderGovernanceCommitteeCmds cmds | |||
EraBasedGovernanceActionCmds cmds -> | |||
renderGovernanceActionCmds cmds | |||
EraBasedGovernanceDRepGenerateKey{} -> "governance drep key-gen" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about having a single key generation command that generates all the different keys? cc: @newhoggy @disassembler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds like a really good idea!
Changelog
Context
Implements #128
Checklist
See Running tests for more details
.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7