Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(demo): update demo app with new features #133

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

goncalo-frade-iohk
Copy link
Contributor

@goncalo-frade-iohk goncalo-frade-iohk commented Apr 12, 2024

Description:

Update demo app with new UI.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@@ -0,0 +1,356 @@
import Domain
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this PR contains logic for the backup?!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it was a mistake already removed.

@@ -0,0 +1,32 @@
//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove copyright

@@ -0,0 +1,214 @@
//
// HyperlinkText.swift
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove copyright

@@ -0,0 +1,97 @@
//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove copyright

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done also to all the above

Copy link
Contributor

@elribonazo elribonazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@goncalo-frade-iohk goncalo-frade-iohk merged commit 931c843 into main Apr 15, 2024
3 checks passed
@goncalo-frade-iohk goncalo-frade-iohk deleted the feature/update-demo-app branch April 15, 2024 11:32
atala-dev added a commit that referenced this pull request May 3, 2024
# [6.0.0](5.0.3...6.0.0) (2024-05-03)

* feat!(pollux): add jwt and anoncreds verification ([8e9e959](8e9e959))

### Features

* **demo:** update demo app with new features ([#133](#133)) ([931c843](931c843))

### BREAKING CHANGES

* ProofTypes was replaced by ClaimFilter

- This commit also has a fix with PRISM DID resolution, now it correctly resolves all public keys
- It adds a new utility method to castor to retrieve all public keys from a DID

Fixes ATL-6627
@mkbreuningIOHK
Copy link
Contributor

@goncalo-frade-iohk , just for clarification: in the title of the PR, it is mentioning 'a new feature' but in the description, it is not explicitly writing what's the new feature. Could you add this in the PR description?
As from the v6.0.0 release note, it seems to be linked to this new feature: "add jwt and anoncreds verification".

goncalo-frade-iohk added a commit that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants