-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take only a folder of a release zip? #5
Comments
Good morning @goaround could you pls show your |
Good moring @Chrico take a look at this release: https://github.com/deworg/dewp-planet-feed/releases/tag/0.5.1 It comes with a With this {
"script": "production",
"pre-compiled": {
"env": {
"root": {
"adapter": false
},
"$default": {
"source": "dewp-planet-feed-${version}",
"target": "./assets/",
"adapter": "gh-release-zip",
"config": {
"repository": "deworg/dewp-planet-feed"
}
}
}
}
} |
@goaround the solution IMO is that in your worflow file you create a zip with just the assets. So right after this line: https://github.com/deworg/dewp-planet-feed/blob/master/.github/workflows/deploy-workflow.yml#L31 you could add:
creating another zip for just assets, and then, at the end of the worflow, you add an additional step: - name: Upload assets ZIP to release.
uses: actions/upload-release-asset@v1
with:
upload_url: ${{ steps.get_release.outputs.upload_url }}
asset_path: ./dewp-planet-feed-assets.zip
asset_name: dewp-planet-feed-assets.zip
asset_content_type: application/zip (I'm not sure At that point, your configuration you could be: {
"script": "production",
"pre-compiled": {
"env": {
"root": {
"adapter": false
},
"$default": {
"source": "dewp-planet-feed-assets.zip",
"target": "./assets/",
"adapter": "gh-release-zip",
"config": {
"repository": "deworg/dewp-planet-feed"
}
}
}
}
} Addding an additional configuration to target a single folder would require some more compexity due to manage yet another config value, plus dealing with it when unpacking the zip. Considering that this is something doable already I'm not sure I want to implement that... I'll have to think about it. Opinions? (also @Chrico) |
Thank you. I now generate an additional assets.zip and this works fine. |
Hi,
first: thank you very much for this composer plugin!
I have a suggestion for pre-compiled adapter: It would be helpful to take only a part e.g. the
dist
orasset
folder from the zip file and place it in the target folder.Often you attach a compiled zip to the Github release with all the files but just need one folder with the assets.
The text was updated successfully, but these errors were encountered: