bug(RVX Manager): the bug in Github API calls and the number of patch options first loaded

[ghost]

Type

Error at runtime

Tools used

RVX Manager

Application

RVX Manager v1.20.4, v1.21.1

Bug description

1. The issues below still persist. I am using AdGuard and have not set any exceptions on purpose, and this symptom does not occur at all in ReVanced Manager.
   "Updates" section in RVX Manager loads indefinitely  #1956
   

2. Deleted (ReVanced manager issue)

Error logs

No response

Solution

1. Please merge the relevant patch of ReVanced Manager.
   fix: Cache external API calls  ReVanced/revanced-manager#1911
   I've been waiting for this patch to be merged, but it hasn't worked, so I'm requesting it. This method is better than the way you fixed it.

2. Well, IDK. At least in ReVanced Manager, the patch loading speed itself is much faster.

Additional context

Thanks

Device Environment

Android 14

Acknowledgements

• This issue does not reproduce on unpatched YouTube or YT Music.
• This issue is not a duplicate of an existing bug report.
• I have chosen an appropriate title.
• All requested information has been provided properly.
• I have written the title and contents in English.

[inotia00]

1. The issue may not be reproduced in ReVanced Manager, but may be reproduced only in RVX Manager

This is because the official ReVanced uses its own ReVanced API, while RVX uses Github API

2. The PR you mentioned is already reflected in RVX Manager 1.21.1

I maintain RVX just as a hobby, so I don't plan to host a webpage for RVX or implement an API

Most bugs that occur in RVX Manager will not be fixed, and users can try other patching methods other than RVX Manager

(This is also mentioned in the release notes of RVX Manager)

[ghost]

1. I experimented with the same RVX source, so I believe there was a difference in the same Github API environment, but maybe I misunderstood.

2. I mentioned that the problem seems to be recurring in v1.21.1, but I'll have to wait and see.

Ok, I left this post in case you missed something, so I would appreciate it if you could understand.

[ghost]

To correct, symptom no.1 did not appear in v1.20.4 and recurred in v1.21.1, If i load the source once and load it again, the symptom appears immediately. Is your solution for symptom no.1 also valid in v1.21.1? And if you look at the link to my solution no.1, ReVanced Manager dealt with the exact same symptom and resolved the abnormal GitHub API rate limit exceedance.

[ghost]

Symptom no.2 also appeared in v1.21.1. Not when loading a latest patch itself from a registered source, only when loading for the first time the a newly updated version after the time of source registration, the number of patch options is displayed as 0 and the Suggested version is displayed as Any version. Since the patch itself was loaded properly, the symptoms are completely different from those when the patch failed to load.

[ghost]

@inotia00 Are the above two symptoms not reproduced on your device? #2315 may also be a problem caused by the first symptom. Both symptoms occur equally when loading your source following the process below.
RVX Manager > Patcher > Select an app

The first symptom occurs when you load the source for the first time and then force quit RVX Manager and then try to load the source. Even when AdGuard is turned off, the same problem occurs and recurs in v1.21.1. Your solution worked only in v1.20.4, so the bug didn't appeared equally when I turned on AdGuard.

ReVanced/revanced-manager#1911

This solution resolves the exact same symptom for abnormal Github API Calls. This is not at all about the ReVanced API.

The second symptom occurs when you first loading the source and then force quit RVX Manager and then you release new version and then successfully load the source (by network change, etc). This is also a bug that has nothing to do with AdGuard, but has existed since v1.20.4. It appears the same in v1.21.1.

[inotia00]

RVX Manager is provided simply for my patch compatibility

There are no plans to fix bugs in RVX Manager

(This is also mentioned in the RVX Manager release notes)

Please use a different patching method than RVX Manager

[ghost]

@inotia00 It doesn't matter if you ignore this comment.
But these are details about a bug that has already been reported, and I write this comment in the hope that it will be helpful as there is a problem with your patch compatibility.

As I continue testing, I write down more detailed symptoms I find.

The first bug (abnormal Github API calls) is a new bug in RVX Manager that is different from any existed bugs. Reprodution is possible when both conditions below are met.

1. Use pre-release is on.
2. App theme is Dark or Material You.

It doesn't seem to be related to the solution I suggested, so it would be good if you could examine it.

But the second bug was an error on the official ReVanced Manager side. It took a long time to check because the stable version had a long release term, but it was a simple problem that could be reproduced by loading the source as soon as it was newly installed. I will report this to the ReVanced Team. Sorry.

[ghost]

The first bug (abnormal Github API calls) is a new bug in RVX Manager that is different from any existed bugs. Reprodution is possible when both conditions below are met.

1. Use pre-release is on.
2. App theme is Dark or Material You.

Are the above symptoms not reproducible on your device? Just curious.

[ghost]

Amazingly it's fixed in v1.22.2! It's awesome. Error No.2 also looks like oSumAtrIX will fix it soon. Always thank you for hard work.

[inotia00]

Maybe it's because I changed the Header to include PAT when sending a request to Github API

https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api?apiVersion=2022-11-28

(I didn't include PAT in the source code because it is a unique value)

[ghost]

It is interesting that even if i load the source only twice in a row the error occurred only when I changed the theme in addition to the pre-release because there are written that the primary rate limit for non-PAT requests is 60 requests per hour. Did you include your PAT?

[inotia00]

Yes, I have included my PAT in the latest manager build

[ghost]

I checked today and the problem occurred again. It happens even if the app is just restarted to load the source under the same conditions. I think the problem occurred after I turned off Save patched app. I turned it back on, but it's the same. I'm not sure if it's related. I guess I'll have to use the Original theme again.

[inotia00]

Even if I include PAT in my RVX manager build, the Github API rate limit is only increased from 60 requests per hour to 5000 requests per hour

The frequency of the rate limit toast is noticeably reduced compared to before, but the issue is still valid

The issue has been closed with not planned, so please do not mention me on this issue anymore

[ghost]

Ok, I'll make this the last comment. I won't mention this issue anymore, whether it's fixed or not. The only question I had was why the issue occurs only when the manager's theme is dark or Material You. In fact, the issue occurs even if the pre-release is reload just once, and it still resets when the IP is changed, so it seems that no matter how much you've responded to the Github API rate limit so far, it wasn't valid only for those themes to which it doesn't apply. Sorry for bothering you unintentionally.