Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion(YouTube - Hide fullscreen ads): Remove toast being shown when hiding fullscreen ad #2167

Closed
5 tasks done
ILoveOpenSourceApplications opened this issue Jun 18, 2024 · 2 comments
Labels
Suggestion Leave any other suggestions

Comments

@ILoveOpenSourceApplications

Application

YouTube

Suggestion description

Currently, the Hide fullscreen ads toast shows up when it hides ads as well as when it hides some other UI elements, like opening community posts images. It feels unwanted to have a toast show up when ads are hidden, whereas if it's when it's hiding a UI element, it'll help the user identify what's causing the issue.

Also, there are users who hide community posts and for them having a toast pop-up simply when hiding an ad just feels unnecessary.

So, if possible, the toast can be avoided when hiding ads and only pop-up when hiding UI elements would be perfect.

Screenshot_20240618_213256_YouTube

Acknowledgements

  • This issue is not a duplicate of an existing suggestion.
  • This is not a feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@ILoveOpenSourceApplications ILoveOpenSourceApplications added the Suggestion Leave any other suggestions label Jun 18, 2024
@inotia00
Copy link
Owner

This toast is needed to resolve the issue #2017

This is because it is not yet known what type of dialog is used in community posts image

@inotia00
Copy link
Owner

If the dialog type used in community post images becomes known,
Close fullscreen ads setting will not be necessary and the toast will also be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Suggestion Leave any other suggestions
Projects
None yet
Development

No branches or pull requests

2 participants