Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: RVX Manager - apps list is empty (unless source is original revanced repos) #1331

Closed
5 tasks done
kulmegil opened this issue Sep 6, 2023 · 13 comments
Closed
5 tasks done
Labels
Bug report Something isn't working

Comments

@kulmegil
Copy link

kulmegil commented Sep 6, 2023

Type

Other

Tools used

ReVanced Manager

Application

RvX Manager v1.9.5

Bug description

No apps appear on apps list selection in Patcher section.
This forces user to select .apk from storage, preventing use of root installation when patching is finished

Steps to reproduce

  1. Launch RvX Manager
  2. Click "Select an application" in Patcher tab

Relevant log output

-

Screenshots or videos

Screenshot_20230906-131837

Solution

[troublesome workaround]

  1. temporary switching repos to revanced (don't restart manager app)
  2. select app from the list
  3. reset repos back to intotia00
  4. continue patching
  5. select root install

Additional context

API url is set to api.revanced.app/

There is a similar bug opened at Revanced Manager. I'm not sure if it will reach proper conclusion since it "works right" when original revanced repos are selected.

Device Environment

OnePlus 8T Android 11 (not releavant it)

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
  • I have written the title and contents in English.
  • This issue does not reproduce on unpatched YouTube or YT Music.
@kulmegil kulmegil added the Bug report Something isn't working label Sep 6, 2023
@inotia00
Copy link
Owner

inotia00 commented Sep 6, 2023

Since my patch only supports three apps, there is no need to load a list of all the apps it supports.

The documentation also recommends importing the APK from local storage.

So I have no plans to fix

@inotia00 inotia00 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2023
@KobeW50
Copy link
Contributor

KobeW50 commented Sep 6, 2023

Since my patch only supports three apps, there is no need to load a list of all the apps it supports.

The documentation also recommends importing the APK from local storage.

What about root installs?

@inotia00
Copy link
Owner

inotia00 commented Sep 6, 2023

Even in a ROOT environment, you just need to locally get the APK of the same version as the app installed on your device.

Because this screen is still displayed
(current version, suggested version)

RVX Manager

Selecting an app from the list of installed apps takes slightly longer to patch, so I recommend pulling the APK locally

@KobeW50
Copy link
Contributor

KobeW50 commented Sep 6, 2023

Even in a ROOT environment, you just need to locally get the APK of the same version as the app installed on your device.

Im not sure I understand what you mean when you say "locally"

Are you saying that as long as the installed app on your device is the same version as the one selected from storage you will be able to do a root install?

So if you want to do a root install of YTM 6.17.52, you would install the YTM 6.17.52 apk, then open the manager and select a 6.17.52 apk from storage and then patch. And then when patching is complete the root install option will work

Because this screen is still displayed
(current version, suggested version)

But the current version (on that screen) is the version that is selected, whether it was selected from the apps list or from storage.

@inotia00
Copy link
Owner

inotia00 commented Sep 6, 2023

This means pressing the ‘Storage’ button to select the APK downloaded from APKMirror.

If the user selects an incorrect version of the APK, this will appear:

RVX Manager

(Current version and Suggested version do not match)

This is what my documentation says:

After downloading the APK from APKMirror, 'install it on the device'

and then, select the APK by pressing the Storage button

@kulmegil
Copy link
Author

kulmegil commented Sep 6, 2023

I had already tried it in the past and it never worked. It doesn't work now with latest versions either...

  1. Unpatched previous installation
  2. Downloaded YT apk (18.34.40) from APKmirror
  3. Installed it "on the device" (using standard android package manager)
  4. Selected the very same apk using "Storage" button on Patcher page
  5. Patch finished successful
  6. Selected root installation type.... got error

@inotia00
Copy link
Owner

inotia00 commented Sep 6, 2023

I had already tried it in the past and it never worked. It doesn't work now with latest versions either...

  1. Unpatched previous installation
  2. Downloaded YT apk (18.34.40) from APKmirror
  3. Installed it "on the device" (using standard android package manager)
  4. Selected the very same apk using "Storage" button on Patcher page
  5. Patch finished successful
  6. Selected root installation type.... got error

exclude MicroG support patch

@kulmegil
Copy link
Author

kulmegil commented Sep 7, 2023

I always excluded it for root installation. It was excluded in the screenshots above.

But it does nothing since the problem is RvX Manager refuses to install it as root at the end of patching.

edit: in fact the when "MicroG support" patch is excluded Manager will refuse to install it as non root AND as root both at the same time

@Neocray
Copy link

Neocray commented Sep 9, 2023

Same issue here. Patched APK also refuses to install as root.

@inotia00
Copy link
Owner

inotia00 commented Sep 14, 2023

I am not using RVX Manager as my main tool, and I am not good at handling flutter, so when I first released RVX Manager, I declared that I would not fix any issues that users encounter.
(Because there are many other tools to build RVX besides RVX Manager)

But @oop7, thanks to you for providing very specific steps to reproduce the error, I was able to fix this issue. #1357 (comment)

Fixed in RVX Manager v1.9.7

@KobeW50
Copy link
Contributor

KobeW50 commented Sep 15, 2023

@inotia00, do you plan on changing step 5 in the RVX Manager doc that rooted installers should pick the YT application instead of from storage?

@kulmegil
Copy link
Author

Has selecting from storage ever worked with root installation?
I tried a few times already with different versions and it never did for me, despite following those readme's and guides to the letter. Am I autistic and missed some very obvious step along the way?

That being said I can confirm 1.9.7 is working as expected for me. Thank You for fixing this.

@inotia00
Copy link
Owner

@inotia00, do you plan on changing step 5 in the RVX Manager doc that rooted installers should pick the YT application instead of from storage?

Wiki needs to be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants