Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement copying files #43

Closed
4 tasks done
obiwac opened this issue Jul 10, 2023 · 0 comments · Fixed by #45
Closed
4 tasks done

Reimplement copying files #43

obiwac opened this issue Jul 10, 2023 · 0 comments · Fixed by #45
Labels
enhancement New feature or request high-priority Should do this as quickly as possible

Comments

@obiwac
Copy link
Member

obiwac commented Jul 10, 2023

This was removed in 5ac5067 because it was implemented poorly.

A new implementation must satisfy the following requirements:

  • Friendly to shell globbing (e.g. aquarium pointer -y files/* /tmp should work, as before).
  • Works recursively, so no simple fcopyfile (should prolly do as in Bob the Builder for this, in fine it'd be nice to have a common header-only library for these kinds of stupid FS functions).
  • Is safe; you shouldn't be able to copy over files you don't have access to so you can read them.
  • Respects permissions, but I have approx 0 clue how to go about this. Do I set all UID's and GID's to 0?

(Personal note: once this is all done, I can work on the new images for Ananas!)

@obiwac obiwac added enhancement New feature or request high-priority Should do this as quickly as possible labels Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high-priority Should do this as quickly as possible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant