Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home - Landing Page #115

Open
3 tasks done
lloan opened this issue Mar 10, 2020 · 13 comments
Open
3 tasks done

Home - Landing Page #115

lloan opened this issue Mar 10, 2020 · 13 comments
Assignees
Labels
in progress Task that is being worked on. task scrum label
Milestone

Comments

@lloan
Copy link
Member

lloan commented Mar 10, 2020

This is a three part task:

  • Design the new page
  • Create the proof of concept
  • Implement the proof of concept

Design

What is the new component or item:
Create a design PDF for developers to create a static copy with code. You will be using UIKit components along with Fontawesome PRO icons. Any comments you need to make, make them in the discussion of the issue or the implementation issue for this component.

The expected deliverable will be a design documents that shows all the possible states it has. Provide notes as necessary.

** Proof of Concept**

Create a proof of concept using Storybook.js. Take the design PDF and convert it to code. You will be using UIKit as the CSS library along with Fontawesome PRO icons. Do not worry about logic during this step, just build out the component.

The expected deliverable will be a component that is responsive and mobile-ready. Make sure you address all stories requested (states). The next task will deal with adding any additional logic that might be needing. For example, creating API requests, iterating through data, etc.

Implement the Proof of Concept

Take the proof of concept and add missing logic. This means take it from static and make it dynamic if it requires it. Build it to be modular, add comments and make sure component is polished.

@lloan lloan added the task scrum label label Mar 10, 2020
@lloan lloan added this to the MVP milestone Mar 10, 2020
@lloan
Copy link
Member Author

lloan commented Mar 10, 2020

Both design over and specs sheet provided. Page ready to be built.

JPGs: (specs and design)
home-landing-page-specs
home-landing-page

PDFs: (specs)
home-landing-page-specs.pdf

@lloan
Copy link
Member Author

lloan commented Mar 10, 2020

@tonynguyen111997 @HeyItsFelipe @VelazquezLuis need some help finding images to put within the placeholder sections of the design. Maybe we can do a photoshoot or something just for this? Let me know :)

@lloan lloan assigned lloan and saynegrojas and unassigned lloan Mar 10, 2020
@lloan
Copy link
Member Author

lloan commented Mar 17, 2020

@saynegrojas how is this going?

@lloan lloan added the in progress Task that is being worked on. label Mar 17, 2020
@lloan
Copy link
Member Author

lloan commented Mar 24, 2020

@saynegrojas Hi Greg! Any update on this one? Thanks!

@saynegrojas
Copy link
Contributor

@lloan Lloan, I've got the top half 90% complete on the proof of concept. I'll be working on the lower half as soon as I can.

@JacobSNGoodwin JacobSNGoodwin self-assigned this Apr 23, 2020
@JacobSNGoodwin
Copy link
Contributor

@lloan and @saynegrojas , I got asked to finish this up by @kvera001.

Underneath the React Fundamentals course, there are some little dots. Is the course supposed to scroll? Just making sure that's the idea there, so I can add the proper data property (I can add multiple course examples as data into the component.

@lloan
Copy link
Member Author

lloan commented Apr 24, 2020

@JacobSNGoodwin for now, let's skip them as we will only have one item showing up. But in the future, yes, it would scroll.

@JacobSNGoodwin
Copy link
Contributor

I have this working pretty well design wise. I may have some questions about the data structure we want, but I'll get on adding react props soon.

https://github.com/inland-empire-software-development/spark/tree/landing-page-115-jg

@JacobSNGoodwin
Copy link
Contributor

@tonynguyen111997 @HeyItsFelipe @VelazquezLuis need some help finding images to put within the placeholder sections of the design. Maybe we can do a photoshoot or something just for this? Let me know :)

Hey guys, I'm adding some sample data to be passed into this component with react props.

Do you have any sample images as @lloan requested a while back?

@JacobSNGoodwin
Copy link
Contributor

I just implemented the react props for this which can are demoed in storybook. #135 should close this when merged.

@lloan
Copy link
Member Author

lloan commented May 18, 2020

Hi @JacobSNGoodwin can you do me a favor? Can you include the steps for testing? Meaning, what page do I load, is it in storybook or not, etc.

Thanks! I will have time this week as I'm almost done with my two large projects at work. Thanks a ton for the work you do!

@JacobSNGoodwin
Copy link
Contributor

@lloan, I'll add details to the PR #138

@JacobSNGoodwin
Copy link
Contributor

I just ended up merging it, #138. Don't know if we close this or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Task that is being worked on. task scrum label
Projects
None yet
Development

No branches or pull requests

3 participants