Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning for loose ends inside weaves #416

Closed
joningold opened this issue Mar 9, 2018 · 5 comments
Closed

Warning for loose ends inside weaves #416

joningold opened this issue Mar 9, 2018 · 5 comments

Comments

@joningold
Copy link
Member

The following source

=== knot 
    *   Option 

doesn't produce a loose end warning; meaning it's pretty easy to accidentally create a flow that dies at runtime. If the compiler could detect this, and warn, that would be epic.

@joethephish
Copy link
Member

Ah yeah, I noticed that before but forgot to log it, that's definitely a biggie.

@KeineLimonade
Copy link

Only partially related to this issue, but I think someone should create a test suite for ink. This is a pretty simple file and it should not be possible to mess flow up that easily....

I could do this in spring break (in may). Maybe I will also implement this enhancement then.

@joethephish
Copy link
Member

joethephish commented Mar 13, 2018 via email

@ZephyrRaine
Copy link

After discussing this issue on Discord, we did an auto-tester that get all knots and stitches in the game, then plays them all and check if the story's state raise any error. It looks like these dead-ends do raise an error.

I don't know if that helps in any way but it's our workaround.

@joethephish
Copy link
Member

Fixed in de744ae.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants