-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning for loose ends inside weaves #416
Comments
Ah yeah, I noticed that before but forgot to log it, that's definitely a biggie. |
Only partially related to this issue, but I think someone should create a test suite for ink. This is a pretty simple file and it should not be possible to mess flow up that easily.... I could do this in spring break (in may). Maybe I will also implement this enhancement then. |
There’s already a test suite in the C# ink codebase. Just need to add this obvious case!
…On 13 Mar 2018, 15:40 +0000, Juli ***@***.***>, wrote:
Only partially related to this issue, but I think someone should create a test suite for ink. This is a pretty simple file and it should not be possible to mess flow up that easily....
I could do this in spring break (in may). Maybe I will also implement this enhancement then.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
After discussing this issue on Discord, we did an auto-tester that get all knots and stitches in the game, then plays them all and check if the story's state raise any error. It looks like these dead-ends do raise an error. I don't know if that helps in any way but it's our workaround. |
Fixed in de744ae. |
The following source
doesn't produce a loose end warning; meaning it's pretty easy to accidentally create a flow that dies at runtime. If the compiler could detect this, and warn, that would be epic.
The text was updated successfully, but these errors were encountered: