Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build improvement: enable no-explicit-any ESLint rule as an error #375

Open
43081j opened this issue Jan 10, 2022 · 1 comment
Open

build improvement: enable no-explicit-any ESLint rule as an error #375

43081j opened this issue Jan 10, 2022 · 1 comment

Comments

@43081j
Copy link
Collaborator

43081j commented Jan 10, 2022

This should already be throwing warnings unless we disabled it explicitly.

We should:

  • Change the level to error
  • Remove all possible eslint-ignore lines which currently disable this rule
  • Remove all usages of any

We have quite a few, so i expect this'll be a sizeable change.

There will inevitably be some we have to keep around, too, because of dependencies typing them poorly (e.g. overriding a dependency's method which has any in its signature).

@wooorm
Copy link
Collaborator

wooorm commented Jan 11, 2022

👍

Maybe useful: https://github.com/plantain-00/type-coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants