Switch to Montgomery representation #663
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Koren-Brand <[email protected]>
…ation as well Signed-off-by: Koren-Brand <[email protected]>
…ar/switch-to-mont
Signed-off-by: Koren-Brand <[email protected]>
HadarIngonyama
requested review from
yshekel,
mickeyasa,
LeonHibnik and
Koren-Brand
HadarIngonyama
commented
Nov 21, 2024
| } | ||
| END_TIMER(ref, "scalar mult double-and-add", true); | ||
|
|
||
| ASSERT_EQ(mult, expected_mult); | ||
| } | ||
|
|
||
| TYPED_TEST(CurveSanity, ECarith) |
There was a problem hiding this comment.
@yuvalingo keep these tests or remove?
HadarIngonyama
commented
Nov 21, 2024
| END_TIMER(u64Mult_asm, "U64-MULT-asm", true); | ||
| } | ||
|
|
||
| #ifndef BARRET |
There was a problem hiding this comment.
keep this test? @Koren-Brand
|
The PR is currently missing mul_const optimization which is critial for the EC adder. Even with that optimization the MSM performance is 5% worse in CUDA - can we find the cause? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the basic field multiplier to be the Montgomery modular multiplier. This means that the Field class now assumes Montgomery as the default representation of elements.
cuda-backend-branch: hadar/gpu_mont_mult