Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard error for ridge regression coefficients computed incorrectly #99

Open
dlaprins opened this issue Jun 1, 2023 · 0 comments
Open

Comments

@dlaprins
Copy link

dlaprins commented Jun 1, 2023

In https://github.com/ing-bank/skorecard/blob/main/skorecard/linear_model/linear_model.py, the standard errors for the coefficients of logistic regression are computed (lines 132-142). For ridge logistic regression, I believe this formula is incorrect: see for example page 12 of [https://arxiv.org/pdf/1509.09169.pdf](these lecture notes).

Similarly I believe the expression is incorrect for lasso logistic regression; I am unaware of an exact expression for the standard error in this case (and by extension, elasticnet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant