#51 Add option to overlap importance on train and test in plot of ShapModelInterpreter #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 24, 2021 15:30
…rtance, summary and dependency plots.
…ce plot. Update docs.
Matgrb
suggested changes
Nov 22, 2021
| plot_type_call = "dot" | ||
| plot_title = f"SHAP Summary plot for {target_set_title[i]} set" | ||
|
|
||
| if target_set == "both": |
There was a problem hiding this comment.
Can you add to notebook docs an example how to make this?
| @@ -225,22 +233,55 @@ def plot( | |||
| raise ValueError("alpha must be a float value betwee 0 and 1") | |||
|
|
|||
| self.min_q, self.max_q, self.alpha = min_q, max_q, alpha | |||
| if other_tdp: | |||
| other_tdp.min_q, other_tdp.max_q, other_tdp.alpha = min_q, max_q, alpha | |||
There was a problem hiding this comment.
What if the other_tdp has lower min_q or higher max_q?
Maybe good to take min and max over quantiles in both plots
| self._target_rate_plot(feature=feature, bins=bins, type_binning=type_binning, ax=ax2) | ||
|
|
||
| ax2.set_xlim(ax1.get_xlim()) | ||
| for i, (tdp, (ax1, ax2)) in enumerate(zip([self, other_tdp], ax_input)): |
There was a problem hiding this comment.
I think this for loop can be a bit more readable. Do you have some idea how?
| @@ -267,7 +308,6 @@ def _dependence_plot(self, feature, ax=None): | |||
| ax.scatter(X[y == 1], shap_val[y == 1], label=self.class_names[1], color="darkred", alpha=self.alpha) | |||
|
|
|||
| ax.set_ylabel("Shap value") | |||
| ax.set_title(f"Dependence plot for {feature} feature") | |||
There was a problem hiding this comment.
Why do you remove the title?
|
@eduardo-lourenco Are you going to still work on this one PR? |
|
hi @eduardo-lourenco thanks for your contributions, could you update your PR to be made compatible with the latest changes on main? |
|
This PR is closed. Please reach out if you want to continue with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets issue #51:
I will update the related tests if this solution seems appropriate (current tests are still passing, we just need to add new tests).