add endpoint for retrieving a user's info by ID #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jnschaeffer
requested changes
Mar 7, 2024
| @@ -162,6 +162,40 @@ func (s userInfoService) LookupUserInfoByID(ctx context.Context, id gidx.Prefixe | |||
| return ui, err | |||
| } | |||
|
|
|||
| // LookupUserOwnerID finds the Owner ID of the Issuer for the given User ID. | |||
| func (s userInfoService) LookupUserOwnerID(ctx context.Context, id gidx.PrefixedID) (gidx.PrefixedID, error) { | |||
There was a problem hiding this comment.
Can we get a test of this?
jnschaeffer
reviewed
Mar 7, 2024
internal/api/httpsrv/handle_user.go
Outdated
Comment on lines
18
to
27
| if err != nil { | ||
| return nil, echo.NewHTTPError(http.StatusNotFound, err) | ||
| } |
There was a problem hiding this comment.
This could fail for reasons that aren't a not found error, right?
There was a problem hiding this comment.
Indeed, I meant to replace these with switch statements. Thanks.
internal/api/httpsrv/handle_user.go
Outdated
Comment on lines
26
to
43
| info, err := h.engine.LookupUserInfoByID(ctx, req.UserID) | ||
| if err != nil { | ||
| return nil, echo.NewHTTPError(http.StatusBadRequest, err) | ||
| } |
There was a problem hiding this comment.
Same re: errors here. This actually looks like a server error.
mikemrm
force-pushed
the
add-get-user-endpoint
branch
from
318deb3 to
4a2020d
Compare
mikemrm
force-pushed
the
add-get-user-endpoint
branch
2 times, most recently
from
4d66d35 to
9420dc1
Compare
This adds an http endpoint for retrieving a users information by the user's ID. Permission is checked by checking the user issuer's owner ID for iam_user_get action. Signed-off-by: Mike Mason <[email protected]>
mikemrm
force-pushed
the
add-get-user-endpoint
branch
from
9420dc1 to
b87c211
Compare
jnschaeffer
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an http endpoint
/api/v1/users/{userID}for retrieving a users information by the user's ID.Permission is checked by checking the user issuer's owner ID for iam_user_get action.