From 0e888eaece968ded2572713746548b4f7cd651c9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre-=C3=89tienne=20Lord?= <pe_lord@yahoo.ca>
Date: Thu, 25 Apr 2019 16:03:23 -0400
Subject: [PATCH 1/4] feat(rotation-btn)Shown if disabled(except mobile)

---
 .../rotation-button/rotation-button.component.html    | 11 ++++-------
 .../rotation-button/rotation-button.component.scss    |  6 ++++++
 .../map/rotation-button/rotation-button.component.ts  |  4 ++++
 packages/geo/src/locale/en.geo.json                   |  3 ++-
 packages/geo/src/locale/fr.geo.json                   |  3 ++-
 5 files changed, 18 insertions(+), 9 deletions(-)

diff --git a/packages/geo/src/lib/map/rotation-button/rotation-button.component.html b/packages/geo/src/lib/map/rotation-button/rotation-button.component.html
index 073a2e5212..aa7fddca77 100644
--- a/packages/geo/src/lib/map/rotation-button/rotation-button.component.html
+++ b/packages/geo/src/lib/map/rotation-button/rotation-button.component.html
@@ -1,10 +1,7 @@
-<div class="igo-rotation-button-container">
-  <button
-    *ngIf="map.viewController.getRotation() !== 0" 
-    mat-icon-button 
-    [matTooltip]="'igo.geo.mapButtons.resetRotation' | translate"
-    matTooltipPosition="left" 
-    [color]="color" 
+<div class="igo-rotation-button-container"
+  [matTooltip]="rotated ? ('igo.geo.mapButtons.resetRotation' | translate): ('igo.geo.mapButtons.tipRotation' | translate)"
+  matTooltipPosition="left">
+  <button mat-icon-button matTooltipPosition="left" [color]="color" [disabled]="!rotated"
     (click)="map.viewController.resetRotation()">
     <mat-icon [ngStyle]="rotationStyle(map.viewController.getRotation())">
       navigation
diff --git a/packages/geo/src/lib/map/rotation-button/rotation-button.component.scss b/packages/geo/src/lib/map/rotation-button/rotation-button.component.scss
index 962260ea58..206f2a264c 100644
--- a/packages/geo/src/lib/map/rotation-button/rotation-button.component.scss
+++ b/packages/geo/src/lib/map/rotation-button/rotation-button.component.scss
@@ -1,3 +1,4 @@
+@import '../../../../../core/src/style/partial/media';
 @import '../../../../../core/src/style/partial/core.variables';
 
 .igo-rotation-button-container {
@@ -11,4 +12,9 @@
 button,
 :host >>> button .mat-button-ripple-round {
   border-radius: 0;
+  &:disabled {
+    @include mobile {
+      display: none;
+    }
+  }
 }
diff --git a/packages/geo/src/lib/map/rotation-button/rotation-button.component.ts b/packages/geo/src/lib/map/rotation-button/rotation-button.component.ts
index cdfe91092c..c532459ea0 100644
--- a/packages/geo/src/lib/map/rotation-button/rotation-button.component.ts
+++ b/packages/geo/src/lib/map/rotation-button/rotation-button.component.ts
@@ -26,6 +26,10 @@ export class RotationButtonComponent {
   }
   private _color: string;
 
+  get rotated(): boolean {
+    return this.map.viewController.getRotation() !== 0;
+  }
+
   constructor() {}
 
   rotationStyle(radians): {} {
diff --git a/packages/geo/src/locale/en.geo.json b/packages/geo/src/locale/en.geo.json
index 1e5c6d463b..6974db666f 100644
--- a/packages/geo/src/locale/en.geo.json
+++ b/packages/geo/src/locale/en.geo.json
@@ -107,7 +107,8 @@
         "geolocate": "Geolocate",
         "zoomIn": "Zoom in ({{zoom}})",
         "zoomOut": "Zoom out ({{zoom}})",
-        "resetRotation": "Set map to north"
+        "resetRotation": "Set map to north",
+        "tipRotation": "Hold ALT and SHIFT while dragging on map to rotate the map."
       },
       "metadata": {
         "show": "Show metadata"
diff --git a/packages/geo/src/locale/fr.geo.json b/packages/geo/src/locale/fr.geo.json
index f5b9efd7b0..5dcd745d3b 100644
--- a/packages/geo/src/locale/fr.geo.json
+++ b/packages/geo/src/locale/fr.geo.json
@@ -107,7 +107,8 @@
         "geolocate": "Positionnement GPS",
         "zoomIn": "Zoomer ({{zoom}})",
         "zoomOut": "Dézoomer ({{zoom}})",
-        "resetRotation": "Réinitialiser la carte vers le nord"
+        "resetRotation": "Réinitialiser la carte vers le nord",
+        "tipRotation": "Maintenez les touches ALT et Majuscule (shift) tout en cliquant sur la carte pour faire ivoter la carte"
       },
       "metadata": {
         "show": "Montrer les métadonnées"

From 222795258a7b7da84c56741c2760de11413eb3f0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre-=C3=89tienne=20Lord?= <pe_lord@yahoo.ca>
Date: Thu, 25 Apr 2019 16:03:59 -0400
Subject: [PATCH 2/4] feat(view) animate view rotation on reset

---
 packages/geo/src/lib/map/shared/controllers/view.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/geo/src/lib/map/shared/controllers/view.ts b/packages/geo/src/lib/map/shared/controllers/view.ts
index 9bedac0391..34b7bf31de 100644
--- a/packages/geo/src/lib/map/shared/controllers/view.ts
+++ b/packages/geo/src/lib/map/shared/controllers/view.ts
@@ -225,7 +225,7 @@ export class MapViewController extends MapController {
    * Reset the view rotation to 0
    */
   resetRotation() {
-    this.olView.setRotation(0);
+    this.olView.animate({rotation: 0});
   }
 
   /**

From 5f1ddc7b349be60437be30a6cdc3e3641872b663 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre-=C3=89tienne=20Lord?= <pe_lord@yahoo.ca>
Date: Thu, 25 Apr 2019 16:06:30 -0400
Subject: [PATCH 3/4] i18n(rotation) typo

---
 packages/geo/src/locale/fr.geo.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/geo/src/locale/fr.geo.json b/packages/geo/src/locale/fr.geo.json
index 5dcd745d3b..de3294f73a 100644
--- a/packages/geo/src/locale/fr.geo.json
+++ b/packages/geo/src/locale/fr.geo.json
@@ -108,7 +108,7 @@
         "zoomIn": "Zoomer ({{zoom}})",
         "zoomOut": "Dézoomer ({{zoom}})",
         "resetRotation": "Réinitialiser la carte vers le nord",
-        "tipRotation": "Maintenez les touches ALT et Majuscule (shift) tout en cliquant sur la carte pour faire ivoter la carte"
+        "tipRotation": "Maintenez les touches ALT et Majuscule (shift) tout en cliquant sur la carte pour faire pivoter la carte"
       },
       "metadata": {
         "show": "Montrer les métadonnées"

From af5017d0b65924daf3a4be17e5856e4bafa96825 Mon Sep 17 00:00:00 2001
From: PE Lord <pe_lord@yahoo.ca>
Date: Tue, 18 Jun 2019 21:39:01 -0400
Subject: [PATCH 4/4] feat(rotation-button)Set option to show/hide

---
 demo/src/app/context/context/context.component.html  |  2 +-
 .../src/app/geo/directions/directions.component.html |  2 +-
 demo/src/app/geo/print/print.component.html          |  2 +-
 .../src/app/geo/simple-map/simple-map.component.html |  2 +-
 .../rotation-button/rotation-button.component.html   | 12 +++++++++++-
 .../map/rotation-button/rotation-button.component.ts |  9 +++++++++
 packages/geo/src/locale/en.geo.json                  |  2 +-
 packages/geo/src/locale/fr.geo.json                  |  2 +-
 8 files changed, 26 insertions(+), 7 deletions(-)

diff --git a/demo/src/app/context/context/context.component.html b/demo/src/app/context/context/context.component.html
index da98a5331f..0a7b6724f9 100644
--- a/demo/src/app/context/context/context.component.html
+++ b/demo/src/app/context/context/context.component.html
@@ -16,7 +16,7 @@
     [map]="map">
     <igo-zoom-button [map]="map" color="primary"></igo-zoom-button>
     <igo-geolocate-button [map]="map" color="primary"></igo-geolocate-button>
-    <igo-rotation-button [map]="map" color="primary"></igo-rotation-button>
+    <igo-rotation-button [map]="map" [showIfNoRotation]="true" color="primary"></igo-rotation-button>
   </igo-map-browser>
 
   <igo-panel title="Contexts list">
diff --git a/demo/src/app/geo/directions/directions.component.html b/demo/src/app/geo/directions/directions.component.html
index 06b50a544b..2503a807c7 100644
--- a/demo/src/app/geo/directions/directions.component.html
+++ b/demo/src/app/geo/directions/directions.component.html
@@ -12,7 +12,7 @@
   <igo-map-browser [map]="map" [view]="view">
     <igo-zoom-button [map]="map" color="primary"></igo-zoom-button>
     <igo-geolocate-button [map]="map" color="primary"></igo-geolocate-button>
-    <igo-rotation-button [map]="map" color="primary"></igo-rotation-button>
+    <igo-rotation-button [map]="map" [showIfNoRotation]="false" color="primary"></igo-rotation-button>
   </igo-map-browser>
 
   <igo-routing-form [map]="map"></igo-routing-form>
diff --git a/demo/src/app/geo/print/print.component.html b/demo/src/app/geo/print/print.component.html
index d24a411dd5..c7865faf9d 100644
--- a/demo/src/app/geo/print/print.component.html
+++ b/demo/src/app/geo/print/print.component.html
@@ -18,7 +18,7 @@
   <igo-map-browser [map]="map" [view]="view">
     <igo-zoom-button [map]="map" color="primary"></igo-zoom-button>
     <igo-geolocate-button [map]="map" color="primary"></igo-geolocate-button>
-    <igo-rotation-button [map]="map" color="primary"></igo-rotation-button>
+    <igo-rotation-button [map]="map" [showIfNoRotation]="false" color="primary"></igo-rotation-button>
   </igo-map-browser>
 
   <igo-print [map]="map"></igo-print>
diff --git a/demo/src/app/geo/simple-map/simple-map.component.html b/demo/src/app/geo/simple-map/simple-map.component.html
index 716527e633..a865626c32 100644
--- a/demo/src/app/geo/simple-map/simple-map.component.html
+++ b/demo/src/app/geo/simple-map/simple-map.component.html
@@ -12,7 +12,7 @@
   <igo-map-browser [map]="map" [view]="view">
     <igo-zoom-button [map]="map" color="primary"></igo-zoom-button>
     <igo-geolocate-button [map]="map" color="primary"></igo-geolocate-button>
-    <igo-rotation-button [map]="map" color="primary"></igo-rotation-button>
+    <igo-rotation-button [map]="map" [showIfNoRotation]="true" color="primary"></igo-rotation-button>
   </igo-map-browser>
 
 </mat-card>
diff --git a/packages/geo/src/lib/map/rotation-button/rotation-button.component.html b/packages/geo/src/lib/map/rotation-button/rotation-button.component.html
index 6e32b737a5..1ab5abf982 100644
--- a/packages/geo/src/lib/map/rotation-button/rotation-button.component.html
+++ b/packages/geo/src/lib/map/rotation-button/rotation-button.component.html
@@ -1,4 +1,14 @@
-<div class="igo-rotation-button-container"
+<div *ngIf="rotated && !showIfNoRotation" class="igo-rotation-button-container"
+  [matTooltip]="rotated ? ('igo.geo.mapButtons.resetRotation' | translate): ('igo.geo.mapButtons.tipRotation' | translate)"
+  matTooltipPosition="left">
+  <button mat-icon-button matTooltipPosition="left" [color]="color" [disabled]="!rotated"
+    (click)="map.viewController.resetRotation()">
+    <mat-icon [ngStyle]="rotationStyle(map.viewController.getRotation())" svgIcon="navigation">
+    </mat-icon>
+  </button>
+</div>
+
+<div *ngIf="showIfNoRotation" class="igo-rotation-button-container"
   [matTooltip]="rotated ? ('igo.geo.mapButtons.resetRotation' | translate): ('igo.geo.mapButtons.tipRotation' | translate)"
   matTooltipPosition="left">
   <button mat-icon-button matTooltipPosition="left" [color]="color" [disabled]="!rotated"
diff --git a/packages/geo/src/lib/map/rotation-button/rotation-button.component.ts b/packages/geo/src/lib/map/rotation-button/rotation-button.component.ts
index c532459ea0..2a3773ca7c 100644
--- a/packages/geo/src/lib/map/rotation-button/rotation-button.component.ts
+++ b/packages/geo/src/lib/map/rotation-button/rotation-button.component.ts
@@ -17,6 +17,15 @@ export class RotationButtonComponent {
   }
   private _map: IgoMap;
 
+  @Input()
+  get showIfNoRotation(): boolean {
+    return this._showIfNoRotation;
+  }
+  set showIfNoRotation(value: boolean) {
+    this._showIfNoRotation = value;
+  }
+  private _showIfNoRotation: boolean;
+
   @Input()
   get color(): string {
     return this._color;
diff --git a/packages/geo/src/locale/en.geo.json b/packages/geo/src/locale/en.geo.json
index 5bcf561d58..e42e86a8d2 100644
--- a/packages/geo/src/locale/en.geo.json
+++ b/packages/geo/src/locale/en.geo.json
@@ -122,7 +122,7 @@
         "zoomIn": "Zoom in ({{zoom}})",
         "zoomOut": "Zoom out ({{zoom}})",
         "resetRotation": "Set map to north",
-        "tipRotation": "Hold ALT and SHIFT while dragging on map to rotate the map."
+        "tipRotation": "Hold Alt and SHIFT while dragging on map to rotate the map."
       },
       "metadata": {
         "show": "Show metadata"
diff --git a/packages/geo/src/locale/fr.geo.json b/packages/geo/src/locale/fr.geo.json
index 64b9519b7d..94fe6b161e 100644
--- a/packages/geo/src/locale/fr.geo.json
+++ b/packages/geo/src/locale/fr.geo.json
@@ -122,7 +122,7 @@
         "zoomIn": "Zoomer ({{zoom}})",
         "zoomOut": "Dézoomer ({{zoom}})",
         "resetRotation": "Réinitialiser la carte vers le nord",
-        "tipRotation": "Maintenez les touches ALT et Majuscule (shift) tout en cliquant sur la carte pour faire pivoter la carte"
+        "tipRotation": "Maintenez les touches Alt et Majuscule (shift) tout en cliquant sur la carte pour faire pivoter la carte"
       },
       "metadata": {
         "show": "Montrer les métadonnées"