Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(geometry-form): drawControl and freehandDraw won't toggle #898

Merged
merged 4 commits into from
Aug 20, 2021

Conversation

olivierSaintCyr
Copy link
Collaborator

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
drawControl and freehandDraw could not be deactivated/activated.

What is the new behavior?
drawControl and freehandDraw can be deactivated/activated.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@olivierSaintCyr olivierSaintCyr changed the base branch from master to next August 17, 2021 16:19
@olivierSaintCyr olivierSaintCyr changed the title Fix geometry form fix(geometry-form): drawControl and freehandDraw Aug 17, 2021
@olivierSaintCyr olivierSaintCyr changed the title fix(geometry-form): drawControl and freehandDraw fix(geometry-form): drawControl and freehandDraw won't toggle Aug 17, 2021
@pelord
Copy link
Member

pelord commented Aug 18, 2021

waiting for @PhilippeLafreniere18 review.

@pelord pelord merged commit b17b1c5 into next Aug 20, 2021
@pelord pelord deleted the FIX-geometry-form branch August 20, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants