Workspace - enabling table view for vector layers #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbourget
requested changes
Jun 10, 2020
packages/geo/src/lib/feature/shared/strategies/loading-layer.ts
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/workspace/workspace-selector/workspace-selector.directive.ts
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/workspace/workspace-button/workspace-button.component.html
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/workspace/workspace-button/workspace-button.component.ts
Outdated
Show resolved
Hide resolved
packages/integration/src/lib/map/map-details-tool/map-details-tool.component.ts
Outdated
Show resolved
Hide resolved
packages/integration/src/lib/map/map-tools/map-tools.component.ts
Outdated
Show resolved
Hide resolved
packages/integration/src/lib/map/map-tools/map-tools.component.ts
Outdated
Show resolved
Hide resolved
cbourget
reviewed
Jun 11, 2020
packages/geo/src/lib/workspace/workspace-selector/workspace-selector.directive.ts
Outdated
Show resolved
Hide resolved
cbourget
reviewed
Jun 11, 2020
packages/integration/src/lib/workspace/workspace-button/workspace-button.component.ts
Outdated
Show resolved
Hide resolved
cbourget
reviewed
Jun 11, 2020
cbourget
reviewed
Sep 11, 2020
cbourget
reviewed
Sep 11, 2020
There was a problem hiding this comment.
I'm not setup no test this and I don't want to stall this PR. Maybe @mbarbeau could take a look at it. I raised some concerns about the entity table columns that have not been adressed but maybe there is no actual issue. Also, this PR has become huge and there is a lot of new stuff (import/export) since my last review that I overlooked but they might deserve a proper review.
remove z-index
… in the current page.
|
linked with infra-geo-ouverte/igo2#471 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: